Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D4A31200C3E for ; Tue, 7 Mar 2017 07:09:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D31F5160B81; Tue, 7 Mar 2017 06:09:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 21D0F160B76 for ; Tue, 7 Mar 2017 07:09:00 +0100 (CET) Received: (qmail 61193 invoked by uid 500); 7 Mar 2017 06:09:00 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 61182 invoked by uid 99); 7 Mar 2017 06:09:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Mar 2017 06:09:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EBA17DFB7D; Tue, 7 Mar 2017 06:08:59 +0000 (UTC) From: ericl To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #17166: [SPARK-19820] [core] Allow reason to be specified... Content-Type: text/plain Message-Id: <20170307060859.EBA17DFB7D@git1-us-west.apache.org> Date: Tue, 7 Mar 2017 06:08:59 +0000 (UTC) archived-at: Tue, 07 Mar 2017 06:09:02 -0000 Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/17166#discussion_r104595023 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -158,7 +158,8 @@ private[spark] class Executor( threadPool.execute(tr) } - def killTask(taskId: Long, interruptThread: Boolean): Unit = { + def killTask( --- End diff -- Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org