Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: viirya <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16944-spark@git.apache.org>
In-Reply-To: <git-pr-16944-spark@git.apache.org>
Subject: [GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...
Content-Type: text/plain
Message-Id: <20170303030846.9FB5ADFC15@git1-us-west.apache.org>
Date: Fri,  3 Mar 2017 03:08:46 +0000 (UTC)
archived-at: Fri, 03 Mar 2017 03:08:48 -0000

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16944#discussion_r104081425
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -597,6 +597,16 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
         }
       }
     
    +  override def alterTableSchema(db: String, table: String, schema: StructType): Unit = withClient {
    +    requireTableExists(db, table)
    +    val rawTable = getRawTable(db, table)
    +    val withNewSchema = rawTable.copy(schema = schema)
    --- End diff --
    
    Why we do two `copy`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org