Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8E37200C2B for ; Thu, 2 Mar 2017 11:19:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E76C5160B6F; Thu, 2 Mar 2017 10:19:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3254D160B61 for ; Thu, 2 Mar 2017 11:19:12 +0100 (CET) Received: (qmail 64271 invoked by uid 500); 2 Mar 2017 10:19:11 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 64260 invoked by uid 99); 2 Mar 2017 10:19:11 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 10:19:11 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1224CDFAB2; Thu, 2 Mar 2017 10:19:11 +0000 (UTC) From: maropu To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #16610: [SPARK-19254][SQL] Support Seq, Map, and Struct i... Content-Type: text/plain Message-Id: <20170302101911.1224CDFAB2@git1-us-west.apache.org> Date: Thu, 2 Mar 2017 10:19:11 +0000 (UTC) archived-at: Thu, 02 Mar 2017 10:19:13 -0000 Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16610#discussion_r103891461 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -99,6 +99,8 @@ object functions { * The passed in object is returned directly if it is already a [[Column]]. * If the object is a Scala Symbol, it is converted into a [[Column]] also. * Otherwise, a new [[Column]] is created to represent the literal value. + * Different from [[lit]], this functions can handle all the types in Scala, --- End diff -- okay, updated. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org