Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: mallman <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16499-spark@git.apache.org>
In-Reply-To: <git-pr-16499-spark@git.apache.org>
Subject: [GitHub] spark pull request #16499: [SPARK-17204][CORE] Fix replicated off heap stora...
Content-Type: text/plain
Message-Id: <20170301030049.E5860DFDE6@git1-us-west.apache.org>
Date: Wed,  1 Mar 2017 03:00:49 +0000 (UTC)
archived-at: Wed, 01 Mar 2017 03:00:51 -0000

Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16499#discussion_r103602156
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -1018,7 +1025,9 @@ private[spark] class BlockManager(
               try {
                 replicate(blockId, bytesToReplicate, level, remoteClassTag)
               } finally {
    -            bytesToReplicate.dispose()
    +            if (!level.useOffHeap) {
    --- End diff --
    
    Ok. I'll see what else is calling that method to validate that a fix there won't break something else, and I'll add a unit test to validate that calling `StorageUtils.dispose` on a direct byte buffer that isn't memory mapped doesn't actually dispose it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org