spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #15821: [SPARK-13534][PySpark] Using Apache Arrow to incr...
Date Thu, 30 Mar 2017 03:39:33 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15821#discussion_r108835232
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -2747,6 +2747,17 @@ class Dataset[T] private[sql](
         }
       }
     
    +  /**
    +   * Collect a Dataset as ArrowPayload byte arrays and serve to PySpark.
    +   */
    +  private[sql] def collectAsArrowToPython(): Int = {
    +    val payloadRdd = toArrowPayloadBytes()
    +    val payloadByteArrays = payloadRdd.collect()
    --- End diff --
    
    @BryanCutler Btw, it is not for performance gain I think. `toLocalIteratorAndServe` can
avoid collect all data at once into the driver. So it may be good for the memory usage on
the driver side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message