spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #17402: [SPARK-7200] Add cleanup for memory leak tests to...
Date Tue, 28 Mar 2017 18:00:08 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17402#discussion_r108491146
  
    --- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
    @@ -25,27 +26,37 @@
     
     public class TaskMemoryManagerSuite {
     
    +  static TaskMemoryManager manager;
    --- End diff --
    
    Does not need to be static. Also should be `private`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message