spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From facaiy <...@git.apache.org>
Subject [GitHub] spark pull request #17407: [SPARK-20043][ML] DecisionTreeModel: ImpurityCalc...
Date Tue, 28 Mar 2017 02:04:37 GMT
Github user facaiy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17407#discussion_r108320537
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
    @@ -385,6 +385,22 @@ class DecisionTreeClassifierSuite
         testEstimatorAndModelReadWrite(dt, continuousData, allParamSettings ++ Map("maxDepth"
-> 0),
           allParamSettings ++ Map("maxDepth" -> 0), checkModelData)
       }
    +
    +  test("SPARK-20043: " +
    +       "ImpurityCalculator builder fails for uppercase impurity type Gini in model read/write")
{
    +    val rdd = TreeTests.getTreeReadWriteData(sc)
    +
    +    val data: DataFrame =
    +      TreeTests.setMetadata(rdd, Map.empty[Int, Int], numClasses = 2)
    +
    +    val dt = new DecisionTreeClassifier()
    +      .setImpurity("Gini")
    +      .setMaxDepth(2)
    +
    +    val model = dt.fit(data)
    +
    +    testDefaultReadWrite(model, false)
    --- End diff --
    
    done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message