spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tcondie <...@git.apache.org>
Subject [GitHub] spark pull request #17444: [SPARK-19876][SS] Follow up: Refactored BatchComm...
Date Tue, 28 Mar 2017 00:26:37 GMT
Github user tcondie commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17444#discussion_r108311230
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/BatchCommitLog.scala
---
    @@ -45,33 +45,39 @@ import org.apache.spark.sql.SparkSession
     class BatchCommitLog(sparkSession: SparkSession, path: String)
       extends HDFSMetadataLog[String](sparkSession, path) {
     
    +  import BatchCommitLog._
    +
    +  def add(batchId: Long): Unit = {
    +    super.add(batchId, EMPTY_JSON)
    +  }
    +
    +  override def add(batchId: Long, metadata: String): Boolean = {
    +    throw new UnsupportedOperationException(
    --- End diff --
    
    What if we want metadata down the road? What's the problem with supporting this for cases
other than null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message