spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #17429: [MINOR][DOCS] Match several documentation changes...
Date Sat, 25 Mar 2017 23:23:12 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17429#discussion_r108047754
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3548,7 +3548,7 @@ setMethod("row_number",
     
     #' array_contains
     #'
    -#' Returns true if the array contain the value.
    +#' Returns null if the array is null, true if the array contains the value, and false
otherwise.
    --- End diff --
    
    Yea, I agree with being careful. For this PR, I followed the others. I skimmed again and
it seems we have not used the notation for `None`, `True` and `False` in `functions.py`, and
`NA, `TRUE` and `FALSE` in both `functions.R`.
    
    I can grep and replace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message