spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request #17426: [SPARK-17137][ML][WIP] Compress logistic regressi...
Date Sat, 25 Mar 2017 17:41:16 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17426#discussion_r108040945
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
    @@ -617,26 +612,13 @@ class LogisticRegression @Since("1.2.0") (
               denseCoefficientMatrix.update(_ - coefficientMean)
             }
     
    --- End diff --
    
    BTW, we could compress the `coefficients` from driver to executors to save communication
cost. Can do in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message