spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #17401: [SPARK-18364][YARN] Expose metrics for YarnShuffl...
Date Fri, 24 Mar 2017 06:09:43 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17401#discussion_r107840363
  
    --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
---
    @@ -0,0 +1,118 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.network.yarn;
    +
    +import com.codahale.metrics.*;
    +import org.apache.hadoop.metrics2.MetricsCollector;
    +import org.apache.hadoop.metrics2.MetricsInfo;
    +import org.apache.hadoop.metrics2.MetricsRecordBuilder;
    +import org.apache.hadoop.metrics2.MetricsSource;
    +
    +import java.util.Map;
    +
    +/**
    + * Modeled off of YARN's NodeManagerMetrics.
    + */
    +public class YarnShuffleServiceMetrics implements MetricsSource {
    +
    +  private final MetricSet metricSet;
    +
    +  public YarnShuffleServiceMetrics(MetricSet metricSet) {
    +    this.metricSet = metricSet;
    +  }
    +
    +  /**
    +   * Get metrics from the source
    +   *
    +   * @param collector to contain the resulting metrics snapshot
    +   * @param all       if true, return all metrics even if unchanged.
    +   */
    +  @Override
    +  public void getMetrics(MetricsCollector collector, boolean all) {
    --- End diff --
    
    Yes, you're right. From my understanding the correctness means `Gauge` still coverts to
`Gauge`, `Meter` still to `Meter`, not sure can it be guaranteed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message