spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request #15628: [SPARK-17471][ML] Add compressed method to ML mat...
Date Wed, 22 Mar 2017 20:13:15 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15628#discussion_r107518109
  
    --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -153,6 +153,86 @@ sealed trait Matrix extends Serializable {
        */
    --- End diff --
    
    BTW, it's nice to have return type in public method. Can you add `Unit` as return type?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message