spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhengruifeng <...@git.apache.org>
Subject [GitHub] spark pull request #17369: [SPARK-20041][DOC] Update docs for NaN handling i...
Date Tue, 21 Mar 2017 08:20:05 GMT
Github user zhengruifeng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17369#discussion_r107094969
  
    --- Diff: R/pkg/R/stats.R ---
    @@ -149,7 +149,8 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"),
     #' This method implements a variation of the Greenwald-Khanna algorithm (with some speed
     #' optimizations). The algorithm was first present in [[http://dx.doi.org/10.1145/375663.375670
     #' Space-efficient Online Computation of Quantile Summaries]] by Greenwald and Khanna.
    -#' Note that rows containing any NA values will be removed before calculation.
    +#' Note that NA values will be ignored in numerical columns before calculation. For
    +#'   columns only containing Na values, an empty list is returned.
    --- End diff --
    
    Good catch. Updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message