spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...
Date Sun, 19 Mar 2017 01:04:23 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17330#discussion_r106795228
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
    @@ -83,6 +116,19 @@ object SubqueryExpression {
           case _ => false
         }.isDefined
       }
    +
    +  /**
    +   * Clean the outer references by normalizing them to BindReference in the same way
    +   * we clean up the arguments during LogicalPlan.sameResult. This enables to compare
two
    --- End diff --
    
    Also replace `SubqueryExpression ` by `CanonicalizedSubqueryExpr`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message