spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...
Date Wed, 15 Mar 2017 17:56:48 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r106233804
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
    @@ -95,7 +95,8 @@ public boolean isFinal() {
       void kill();
     
       /**
    -   * Disconnects the handle from the application, without stopping it. After this method
is called,
    +   * Disconnects the handle from the application. If using {@link SparkLauncher#autoShutdown()}
    +   * option, this method would shutdown stop/kill the application. After this method
is called,
    --- End diff --
    
    Instead of "method would shutdown stop/kill the application", say "this method will also
stop the child Spark application".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message