spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage polic...
Date Wed, 15 Mar 2017 17:15:45 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15604#discussion_r106225480
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
    @@ -191,7 +191,10 @@ private[spark] class FairSchedulableBuilder(val rootPool: Pool, conf:
SparkConf)
             parentPool = new Pool(poolName, DEFAULT_SCHEDULING_MODE,
               DEFAULT_MINIMUM_SHARE, DEFAULT_WEIGHT)
             rootPool.addSchedulable(parentPool)
    -        logInfo("Created pool: %s, schedulingMode: %s, minShare: %d, weight: %d".format(
    +        logWarning(("An Unconfigured pool is found. It is built with default configuration.
" +
    --- End diff --
    
    It's not totally clear what the first part of this error message means.  How about changing
the message to:
    
    ```
    logWarning(s"A job was submitted with scheduler pool $poolName, which has not been configured."
+
        "This can happen when the file that pools are read from isn't set, or when that file
" +
        s"doesn't contain $poolName.  Created $poolName with default configuration (" +
        s"schedulingMode: $DEFAULT_SCHEDULING_MODE, minShare: $DEFAULT_MINIMUM_SHARE, " +
        s"weight: $DEFAULT_WEIGHT)")
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message