spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <>
Subject [GitHub] spark pull request #17278: [SPARK-19933][SQL] Do not change output of a subq...
Date Tue, 14 Mar 2017 09:40:41 GMT
Github user hvanhovell commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
    @@ -140,7 +140,8 @@ abstract class Optimizer(sessionCatalog: SessionCatalog, conf: CatalystConf)
       object OptimizeSubqueries extends Rule[LogicalPlan] {
         def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions {
           case s: SubqueryExpression =>
    -        s.withNewPlan(Optimizer.this.execute(s.plan))
    +        val ReturnAnswer(newPlan) = Optimizer.this.execute(ReturnAnswer(s.plan))
    --- End diff --
    Well extending subquery expression would make it an `Expression`, however I need a `LogicalPlan`.
I will make a new node.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message