spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mridulm <...@git.apache.org>
Subject [GitHub] spark pull request #17244: [SPARK-19889][SQL] Make TaskContext callbacks thr...
Date Fri, 10 Mar 2017 23:34:54 GMT
Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17244#discussion_r105510888
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
    @@ -57,57 +68,75 @@ private[spark] class TaskContextImpl(
       // Whether the task has failed.
       @volatile private var failed: Boolean = false
    --- End diff --
    
    Yes, which is why I mentioned it as extension :-)
    For failed, it is already valid to remove volatile


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message