spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #15628: [SPARK-17471][ML] Add compressed method to ML mat...
Date Thu, 09 Mar 2017 20:19:27 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15628#discussion_r105261250
  
    --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -153,6 +153,86 @@ sealed trait Matrix extends Serializable {
        */
       @Since("2.0.0")
       def numActives: Int
    +
    +  /**
    +   * Converts this matrix to a sparse matrix.
    +   *
    +   * @param columnMajor Whether the values of the resulting sparse matrix should be in
column major
    +   *                    or row major order. If `false`, resulting matrix will be row
major.
    +   */
    +  private[ml] def toSparseMatrix(columnMajor: Boolean): SparseMatrix
    --- End diff --
    
    Should we just leave `toDenseMatrix` private and have `toDense` always use colMajor =
true? I think that's ok to do for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message