spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #16909: [SPARK-13450] Introduce ExternalAppendOnlyUnsafeR...
Date Wed, 08 Mar 2017 20:29:54 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16909#discussion_r105014914
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala
---
    @@ -164,9 +176,12 @@ private[window] final class SlidingWindowFunctionFrame(
       private[this] var inputLowIndex = 0
     
       /** Prepare the frame for calculating a new partition. Reset all variables. */
    -  override def prepare(rows: RowBuffer): Unit = {
    +  override def prepare(rows: ExternalAppendOnlyUnsafeRowArray): Unit = {
         input = rows
    -    nextRow = rows.next()
    +    inputIterator = input.generateIterator()
    +    if (inputIterator.hasNext) {
    --- End diff --
    
    In all fairness: the old code (`rows.next()`) returns `null` if the group is empty. However
in this case the `rows` buffer should contain one or more rows; so an assert might be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message