spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #17182: [SPARK-19840][SQL] Disallow creating permanent fu...
Date Tue, 07 Mar 2017 20:00:18 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17182#discussion_r104764398
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
    @@ -63,7 +63,10 @@ case class CreateFunctionCommand(
         } else {
           // For a permanent, we will store the metadata into underlying external catalog.
           // This function will be loaded into the FunctionRegistry when a query uses it.
    -      // We do not load it into FunctionRegistry right now.
    +      // We do not load it into FunctionRegistry right now. However, we need to validate.
    +      catalog.loadFunctionResources(resources)
    +      catalog.makeFunctionBuilder(functionName, className)
    --- End diff --
    
    Not sure if this is the right direction, but I think we can refactor the whole permanent
function resolution. Let me try it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message