spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #17114: [SPARK-19758][SQL] Resolving timezone aware expre...
Date Sat, 04 Mar 2017 00:30:19 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17114#discussion_r104269428
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -146,7 +146,7 @@ class Analyzer(
           GlobalAggregates ::
           ResolveAggregateFunctions ::
           TimeWindowing ::
    -      ResolveInlineTables ::
    +      ResolveInlineTables(conf) ::
    --- End diff --
    
    I tried before. But the resolution rules will add new timezone-aware expressions, so it
still needs the rule to resolve timezone-aware expressions after resolution rules.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message