spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wojtek-szymanski <...@git.apache.org>
Subject [GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...
Date Thu, 02 Mar 2017 07:29:19 GMT
Github user wojtek-szymanski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17075#discussion_r103864843
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala ---
    @@ -193,7 +193,7 @@ class DecimalSuite extends SparkFunSuite with PrivateMethodTester
{
         assert(Decimal(Long.MaxValue, 100, 0).toUnscaledLong === Long.MaxValue)
       }
     
    -  test("changePrecision() on compact decimal should respect rounding mode") {
    +  test("changePrecision/toPrecission on compact decimal should respect rounding mode")
{
    --- End diff --
    
    Thanks, fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message