Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: thunterdb <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16774-spark@git.apache.org>
In-Reply-To: <git-pr-16774-spark@git.apache.org>
Subject: [GitHub] spark pull request #16774: [SPARK-19357][ML] Adding parallel model evaluatio...
Content-Type: text/plain
Message-Id: <20170217195216.03CC9DFBD3@git1-us-west.apache.org>
Date: Fri, 17 Feb 2017 19:52:16 +0000 (UTC)
archived-at: Fri, 17 Feb 2017 19:52:17 -0000

Github user thunterdb commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16774#discussion_r101834675
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
    @@ -121,6 +121,33 @@ class CrossValidatorSuite
         }
       }
     
    +  test("cross validation with parallel evaluation") {
    +    val lr = new LogisticRegression
    +    val lrParamMaps = new ParamGridBuilder()
    +      .addGrid(lr.regParam, Array(0.001, 1000.0))
    +      .addGrid(lr.maxIter, Array(0, 3))
    +      .build()
    +    val eval = new BinaryClassificationEvaluator
    +    val cv = new CrossValidator()
    +      .setEstimator(lr)
    +      .setEstimatorParamMaps(lrParamMaps)
    +      .setEvaluator(eval)
    +      .setNumFolds(2)
    +      .setNumParallelEval(1)
    +    val cvSerialModel = cv.fit(dataset)
    +    cv.setNumParallelEval(2)
    --- End diff --
    
    this test is not deterministic now. @MLnick , do you know if we have some utilities to retry tests a much of times?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org