Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: felixcheung <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16951-spark@git.apache.org>
In-Reply-To: <git-pr-16951-spark@git.apache.org>
Subject: [GitHub] spark pull request #16951: [SPARK-19619][SPARKR] SparkR approxQuantile suppo...
Content-Type: text/plain
Message-Id: <20170216064543.AF33BDFB0E@git1-us-west.apache.org>
Date: Thu, 16 Feb 2017 06:45:43 +0000 (UTC)
archived-at: Thu, 16 Feb 2017 06:45:45 -0000

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16951#discussion_r101454291
  
    --- Diff: R/pkg/R/stats.R ---
    @@ -149,15 +149,18 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"),
     #' This method implements a variation of the Greenwald-Khanna algorithm (with some speed
     #' optimizations). The algorithm was first present in [[http://dx.doi.org/10.1145/375663.375670
     #' Space-efficient Online Computation of Quantile Summaries]] by Greenwald and Khanna.
    +#' Note that rows containing any NA values will be removed before calculation.
    --- End diff --
    
    it would be good to test that too...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org