Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16674-spark@git.apache.org>
In-Reply-To: <git-pr-16674-spark@git.apache.org>
Subject: [GitHub] spark pull request #16674: [SPARK-19331][SQL][TESTS] Improve the test covera...
Content-Type: text/plain
Message-Id: <20170215183950.E33FCDFC31@git1-us-west.apache.org>
Date: Wed, 15 Feb 2017 18:39:50 +0000 (UTC)
archived-at: Wed, 15 Feb 2017 18:39:53 -0000

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16674#discussion_r101350313
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ---
    @@ -617,13 +617,18 @@ class Analyzer(
         private def lookupTableFromCatalog(
             u: UnresolvedRelation,
             defaultDatabase: Option[String] = None): LogicalPlan = {
    +      val tableIdentWithDb = u.tableIdentifier.copy(database = u.tableIdentifier.database
    --- End diff --
    
    please follow the existing style: https://github.com/apache/spark/pull/16674/files#diff-57b3d87be744b7d79a9beacf8e5e5eb2L622


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org