spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #17087: [SPARK-19372][SQL] Fix throwing a Java exception ...
Date Mon, 27 Feb 2017 19:39:23 GMT
GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/17087

    [SPARK-19372][SQL] Fix throwing a Java exception at df.fliter() due to 64KB bytecode size
limit

    ## What changes were proposed in this pull request?
    
    When an expression for `df.filter()` has many nodes (e.g. 400), the size of Java bytecode
for the generated Java code is more than 64KB. It produces an Java exception. As a result,
the execution fails.
    This PR continues to execute by calling `Expression.eval()` disabling code generation
if an exception has been caught.
    
    ## How was this patch tested?
    
    Add a test suite into `DataFrameSuite`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-19372

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17087
    
----
commit 6f40a93cfb21597b214f930d3a5bd9c6645ef227
Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Date:   2017-02-27T19:35:04Z

    Retry an execution by calling eval() if caught an exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message