spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lw-lin <...@git.apache.org>
Subject [GitHub] spark pull request #16987: [SPARK-19633][SS] FileSource read from FileSink
Date Tue, 28 Feb 2017 08:55:45 GMT
Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16987#discussion_r103403986
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
    @@ -159,28 +161,64 @@ class FileStreamSource(
     
       /**
        * If the source has a metadata log indicating which files should be read, then we
should use it.
    -   * We figure out whether there exists some metadata log only when user gives a non-glob
path.
    +   * Only when user gives a non-glob path that will we figure out whether the source
has some
    +   * metadata log
    +   *
    +   * None        means we don't know at the moment
    +   * Some(true)  means we know for sure the source DOES have metadata
    +   * Some(false) means we know for sure the source DOSE NOT have metadata
    --- End diff --
    
    ( some notes here since the changes are not trival )
    
    here we're using this `sourceHasMetadata` to indicate whether we know for sure the source
has metadata, as stated in the source file comments:
    - `None`        means we don't know at the moment
    - `Some(true)`  means we know for sure the source DOES have metadata
    - `Some(false)` means we know for sure the source DOSE NOT have metadata



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message