spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunalkhamar <...@git.apache.org>
Subject [GitHub] spark pull request #16826: [SPARK-19540][SQL] Add ability to clone SparkSess...
Date Tue, 28 Feb 2017 00:48:35 GMT
Github user kunalkhamar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16826#discussion_r103303272
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
    @@ -90,110 +203,37 @@ private[sql] class SessionState(sparkSession: SparkSession) {
         }
       }
     
    -  /**
    -   * Internal catalog for managing table and database states.
    -   */
    -  lazy val catalog = new SessionCatalog(
    -    sparkSession.sharedState.externalCatalog,
    -    sparkSession.sharedState.globalTempViewManager,
    -    functionResourceLoader,
    -    functionRegistry,
    -    conf,
    -    newHadoopConf(),
    -    sqlParser)
    +  def newHadoopConf(copyHadoopConf: Configuration, sqlConf: SQLConf): Configuration =
{
    --- End diff --
    
    Changed name.
    This is also used in `HiveSessionState.apply`, would be rendered inaccessible if `private`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message