spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16976: [SPARK-19610][SQL] Support parsing multiline CSV ...
Date Sat, 25 Feb 2017 02:18:24 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16976#discussion_r103067531
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
    @@ -243,12 +244,15 @@ class CSVSuite extends QueryTest with SharedSQLContext with SQLTestUtils
{
       }
     
       test("test for DROPMALFORMED parsing mode") {
    -    val cars = spark.read
    -      .format("csv")
    -      .options(Map("header" -> "true", "mode" -> "dropmalformed"))
    -      .load(testFile(carsFile))
    +    Seq(false, true).foreach { wholeFile =>
    --- End diff --
    
    Here also simply I added..
    
    ```scala
    Seq(false, true).foreach { wholeFile =>
      ...
      .option("wholeFile", wholeFile)
      ...
    }
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message