spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #16976: [SPARK-19610][SQL] Support parsing multiline CSV ...
Date Fri, 24 Feb 2017 19:36:19 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16976#discussion_r103012905
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
---
    @@ -86,4 +88,11 @@ object CodecStreams {
           .map(_.getDefaultExtension)
           .getOrElse("")
       }
    +
    +  /** Creates an input stream from the path. */
    --- End diff --
    
    this doesn't tell the difference between this method and `createInputStream(config: Configuration,
file: Path)`.
    
    We also need a better name for this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message