spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage polic...
Date Thu, 23 Feb 2017 22:08:27 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15604#discussion_r102829684
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
    @@ -31,16 +31,17 @@ class PoolSuite extends SparkFunSuite with LocalSparkContext {
       val LOCAL = "local"
       val APP_NAME = "PoolSuite"
       val SCHEDULER_ALLOCATION_FILE_PROPERTY = "spark.scheduler.allocation.file"
    +  val TEST_POOL = "testPool"
     
    -  def createTaskSetManager(stageId: Int, numTasks: Int, taskScheduler: TaskSchedulerImpl)
    +  private def createTaskSetManager(stageId: Int, numTasks: Int, taskScheduler: TaskSchedulerImpl)
    --- End diff --
    
    It's not necessary to make test functions private -- they're not accessible anyway (and
we don't do this elsewhere in tests)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message