spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16928: [SPARK-18699][SQL] Put malformed tokens into a ne...
Date Thu, 23 Feb 2017 06:43:03 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16928#discussion_r102648089
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
---
    @@ -202,21 +221,25 @@ private[csv] class UnivocityParser(
           }
           numMalformedRecords += 1
           None
    -    } else if (options.failFast && schema.length != tokens.length) {
    +    } else if (options.failFast && inputSchema.length != tokens.length) {
           throw new RuntimeException(s"Malformed line in FAILFAST mode: " +
             s"${tokens.mkString(options.delimiter.toString)}")
         } else {
    -      val checkedTokens = if (options.permissive && schema.length > tokens.length)
{
    -        tokens ++ new Array[String](schema.length - tokens.length)
    -      } else if (options.permissive && schema.length < tokens.length) {
    -        tokens.take(schema.length)
    +      val checkedTokens = if (options.permissive && inputSchema.length > tokens.length)
{
    +        tokens ++ new Array[String](inputSchema.length - tokens.length)
    +      } else if (options.permissive && inputSchema.length < tokens.length)
{
    +        tokens.take(inputSchema.length)
           } else {
             tokens
           }
     
           try {
             Some(convert(checkedTokens))
           } catch {
    +        case NonFatal(e) if options.permissive =>
    +          val row = new GenericInternalRow(requiredSchema.length)
    +          corruptFieldIndex.map(row(_) = UTF8String.fromString(input))
    --- End diff --
    
    BTW, I would like to note that this change is actually an important point that we should
avoid. This could cause some bugs that are hard to figure out. (see [SPARK-16694](https://issues.apache.org/jira/browse/SPARK-16694))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message