spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16928: [SPARK-18699][SQL] Put malformed tokens into a ne...
Date Wed, 22 Feb 2017 01:57:09 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16928#discussion_r102367607
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
---
    @@ -189,9 +205,10 @@ private[csv] class UnivocityParser(
         }
       }
     
    -  private def convertWithParseMode(
    -      tokens: Array[String])(convert: Array[String] => InternalRow): Option[InternalRow]
= {
    -    if (options.dropMalformed && schema.length != tokens.length) {
    +  private def parseWithMode(input: String)(convert: Array[String] => InternalRow)
    +    : Option[InternalRow] = {
    --- End diff --
    
    Oh, one more, it seems it fits into 100 line length limit?
    
    ```scala
    private def convertWithParseMode(
        input: String)(convert: Array[String] => InternalRow): Option[InternalRow] = {
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message