spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #16923: [SPARK-19038][Hive][YARN] Correctly figure out ke...
Date Wed, 22 Feb 2017 01:11:26 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16923#discussion_r102361738
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
    @@ -106,21 +106,27 @@ private[hive] class HiveClientImpl(
     
         // Set up kerberos credentials for UserGroupInformation.loginUser within
         // current class loader
    -    // Instead of using the spark conf of the current spark context, a new
    -    // instance of SparkConf is needed for the original value of spark.yarn.keytab
    -    // and spark.yarn.principal set in SparkSubmit, as yarn.Client resets the
    -    // keytab configuration for the link name in distributed cache
    -    if (sparkConf.contains("spark.yarn.principal") && sparkConf.contains("spark.yarn.keytab"))
{
    +    if (sparkConf.contains("spark.yarn.principal")) {
    --- End diff --
    
    Ok, I think I can see a cleaner solution that what I proposed. Sorry for flip-flopping
on this.
    
    Instead of overwriting the `KEYTAB` value in Client.scala, instead, how about:
    - keep the keytab name in an instance variable
    - don't update SparkConf, and use the instance variable in the `distribute` call (around
L470)
    - when writing the AM conf, overwrite `KEYTAB.key` in the properties instance (around
L708)
    
    That avoids the second config, and keeps all the code to handle the different locations
in one place (Client.scala), without having to change anywhere else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message