spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brkyvz <...@git.apache.org>
Subject [GitHub] spark issue #16744: [SPARK-19405][STREAMING] Support for cross-account Kines...
Date Tue, 21 Feb 2017 22:49:53 GMT
Github user brkyvz commented on the issue:

    https://github.com/apache/spark/pull/16744
  
    @budde I'm just concerned by the exponential blowoff of APIs. Here's my proposal.
    For both Java and Scala, let's just add the APIs with both STS token and AWS Key pair
defined versions. I'm going to comment on the PR the APIs that we should remove. Then we can
add the builder pattern in the follow up just to make things easier (if we're going to add
that anyway, it's unnecessary to support all complex combinations here in this PR anyway)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message