spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #16826: [SPARK-19540][SQL] Add ability to clone SparkSess...
Date Tue, 21 Feb 2017 07:04:03 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16826#discussion_r102142543
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ---
    @@ -117,9 +122,11 @@ class SparkSession private(
       @InterfaceStability.Unstable
       @transient
       lazy val sessionState: SessionState = {
    -    SparkSession.reflect[SessionState, SparkSession](
    -      SparkSession.sessionStateClassName(sparkContext.conf),
    -      self)
    +    parentSessionState
    +      .map(_.copy(this))
    --- End diff --
    
    As this is a lazy val, the cloned `SparkSession` will not copy parent `SessionState` immediately.
So if the parent `SessionState` is changed, e.g., new functions registered, before this lazy
variable initialization, the cloned one will also have new functions.
    
     It will not match the description `...Changes to base session are not propagated to cloned
session, cloned is independent after creation...` below.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message