spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunalkhamar <...@git.apache.org>
Subject [GitHub] spark pull request #16826: [SPARK-19540][SQL] Add ability to clone SparkSess...
Date Tue, 21 Feb 2017 06:07:46 GMT
Github user kunalkhamar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16826#discussion_r102137355
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -1178,4 +1178,34 @@ class SessionCatalog(
         }
       }
     
    +  /**
    +   * Get an identical copy of the `SessionCatalog`.
    +   * The temporary tables and function registry are retained.
    +   * The table relation cache will not be populated.
    +   * @note `externalCatalog` and `globalTempViewManager` are from shared state, don't
need deep copy
    +   * `FunctionResourceLoader` is effectively stateless, also does not need deep copy.
    +   * All arguments passed in should be associated with a particular `SparkSession`.
    +   */
    +  def copy(
    +      conf: CatalystConf,
    +      hadoopConf: Configuration,
    +      functionRegistry: FunctionRegistry,
    +      parser: ParserInterface): SessionCatalog = {
    +
    +    val catalog = new SessionCatalog(
    +      externalCatalog,
    +      globalTempViewManager,
    +      functionResourceLoader,
    +      functionRegistry,
    +      conf,
    +      hadoopConf,
    +      parser)
    +
    +    catalog.currentDb = currentDb
    --- End diff --
    
    yes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message