spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #17002: [SPARK-19669][SQL] Open up visibility for sharedS...
Date Mon, 20 Feb 2017 18:04:38 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17002#discussion_r102069532
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ---
    @@ -95,16 +95,26 @@ class SparkSession private(
       /**
        * State shared across sessions, including the `SparkContext`, cached data, listener,
        * and a catalog that interacts with external systems.
    +   *
    +   * This is internal to Spark and there is no guarantee on interface stability.
    +   *
    +   * @since 2.2.0
        */
    +  @InterfaceStability.Unstable
       @transient
    -  private[sql] lazy val sharedState: SharedState = {
    +  lazy val sharedState: SharedState = {
         existingSharedState.getOrElse(new SharedState(sparkContext))
       }
     
       /**
        * State isolated across sessions, including SQL configurations, temporary tables,
registered
        * functions, and everything else that accepts a [[org.apache.spark.sql.internal.SQLConf]].
    +   *
    +   * This is internal to Spark and there is no guarantee on interface stability.
    +   *
    +   * @since 2.2.0
        */
    +  @InterfaceStability.Unstable
       @transient
       private[sql] lazy val sessionState: SessionState = {
    --- End diff --
    
    Like `sharedState`, also remove `private[sql]`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message