spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16928: [SPARK-18699][SQL] Put malformed tokens into a ne...
Date Sat, 18 Feb 2017 14:58:48 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16928#discussion_r101894565
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
---
    @@ -26,7 +26,7 @@ import org.apache.commons.lang3.time.FastDateFormat
     import org.apache.spark.internal.Logging
     import org.apache.spark.sql.catalyst.util.{CaseInsensitiveMap, CompressionCodecs, ParseModes}
     
    -private[csv] class CSVOptions(
    +private[sql] class CSVOptions(
    --- End diff --
    
    `execution` package itself is meant to be a private according to https://github.com/apache/spark/commit/511f52f8423e151b0d0133baf040d34a0af3d422
if this should be accessible other than `csv` package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message