spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ash211 <...@git.apache.org>
Subject [GitHub] spark pull request #16959: [SPARK-19631][CORE] OutputCommitCoordinator shoul...
Date Fri, 17 Feb 2017 14:33:28 GMT
Github user ash211 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16959#discussion_r101762924
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala
---
    @@ -48,25 +48,28 @@ private[spark] class OutputCommitCoordinator(conf: SparkConf, isDriver:
Boolean)
       private type StageId = Int
       private type PartitionId = Int
       private type TaskAttemptNumber = Int
    +  private case class StageState(authorizedCommitters: Array[TaskAttemptNumber],
    --- End diff --
    
    can you put a comment here that the index into the `authorizedCommitters` array is the
partitionId ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message