spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <>
Subject [GitHub] spark pull request #16499: [SPARK-17204][CORE] Fix replicated off heap stora...
Date Fri, 17 Feb 2017 04:01:19 GMT
Github user viirya commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -1018,7 +1025,9 @@ private[spark] class BlockManager(
               try {
                 replicate(blockId, bytesToReplicate, level, remoteClassTag)
               } finally {
    -            bytesToReplicate.dispose()
    +            if (!level.useOffHeap) {
    --- End diff --
    As `StorageUtils.dispose` only cleans up a memory-mapped `ByteBuffer`, I don't think calling
`bytesToReplicate.dispose()` here would be a problem.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message