spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From budde <...@git.apache.org>
Subject [GitHub] spark pull request #16944: [SPARK-19611][SQL] Introduce configurable table s...
Date Thu, 16 Feb 2017 19:30:26 GMT
Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16944#discussion_r101606197
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
---
    @@ -186,8 +212,7 @@ private[hive] class HiveMetastoreCatalog(sparkSession: SparkSession)
extends Log
                 fileFormat = defaultSource,
                 options = options)(sparkSession = sparkSession)
     
    -          val created = LogicalRelation(relation,
    -            catalogTable = Some(metastoreRelation.catalogTable))
    +          val created = LogicalRelation(relation, catalogTable = Some(catalogTable))
    --- End diff --
    
    This would only be appropriate if the mode is INFER_AND_SAVE and the call to ```alterTable()```
succeeds, right? I'll see if I can refactor this method to do this without making it too convoluted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message