spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From budde <...@git.apache.org>
Subject [GitHub] spark pull request #16942: [SPARK-19611][SQL] Introduce configurable table s...
Date Wed, 15 Feb 2017 19:47:07 GMT
Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16942#discussion_r101366441
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -296,6 +296,17 @@ object SQLConf {
           .longConf
           .createWithDefault(250 * 1024 * 1024)
     
    +  val HIVE_SCHEMA_INFERENCE_MODE = buildConf("spark.sql.hive.schemaInferenceMode")
    +    .doc("Configures the action to take when a case-sensitive schema cannot be read from
a Hive " +
    +      "table's properties. Valid options include INFER_AND_SAVE (infer the case-sensitive
" +
    +      "schema from the underlying data files and write it back to the table properties),
" +
    +      "INFER_ONLY (infer the schema but don't attempt to write it to the table properties)
and " +
    +      "NEVER_INFER (fallback to using the case-insensitive metastore schema instead of
inferring).")
    +    .stringConf
    +    .transform(_.toUpperCase())
    +    .checkValues(Set("INFER_AND_SAVE", "INFER_ONLY", "NEVER_INFER"))
    --- End diff --
    
    As mentioned in the PR, I'm looking for a good place to store these values as constants
or an enum.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message