spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imatiach-msft <...@git.apache.org>
Subject [GitHub] spark pull request #16722: [SPARK-19591][ML][MLlib] Add sample weights to de...
Date Wed, 15 Feb 2017 18:01:24 GMT
Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16722#discussion_r101341596
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
    @@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
           subsamplingRate: Double,
           numSubsamples: Int,
           withReplacement: Boolean,
    +      extractSampleWeight: (Datum => Double) = (_: Datum) => 1.0,
           seed: Long = Utils.random.nextLong()): RDD[BaggedPoint[Datum]] = {
    +    // TODO: implement weighted bootstrapping
    --- End diff --
    
    not really related to this review - is there a JIRA for this TODO - and how would it be
done?  Also, considering referencing the JIRA in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message