spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ooq <...@git.apache.org>
Subject [GitHub] spark issue #15193: [SQL]RowBasedKeyValueBatch reuse valueRow too
Date Tue, 14 Feb 2017 06:06:26 GMT
Github user ooq commented on the issue:

    https://github.com/apache/spark/pull/15193
  
    @yaooqinn Do you have any benchmarks on the performance difference? I think pointTo()
is pretty cheap. And does the patch pass the tests? I think valueRow is not updated correctly
in your patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message