spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imatiach-msft <...@git.apache.org>
Subject [GitHub] spark pull request #16630: [SPARK-19270][ML] Add summary table to GLM summar...
Date Tue, 14 Feb 2017 00:15:13 GMT
Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16630#discussion_r100932561
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
    @@ -1152,4 +1170,32 @@ class GeneralizedLinearRegressionTrainingSummary private[regression]
(
             "No p-value available for this GeneralizedLinearRegressionModel")
         }
       }
    +
    +  /**
    +   * Summary table with feature name, coefficient, standard error,
    +   * tValue and pValue.
    +   */
    +  @Since("2.2.0")
    +  lazy val summaryTable: DataFrame = {
    +    if (isNormalSolver) {
    +      var featureNames = featureName
    +      var coefficients = model.coefficients.toArray
    +      var idx = Array.range(0, coefficients.length)
    +      if (model.getFitIntercept) {
    +        featureNames = featureNames :+ "Intercept"
    +        coefficients = coefficients :+ model.intercept
    +        // Reorder so that intercept comes first
    +        idx = (coefficients.length - 1) +: idx
    +      }
    +      val result = for (i <- idx.toSeq) yield
    +        (featureNames(i), coefficients(i), coefficientStandardErrors(i), tValues(i),
pValues(i))
    +
    +      val spark = SparkSession.builder().getOrCreate()
    +      import spark.implicits._
    +      result.toDF("Feature", "Estimate", "StdError", "TValue", "PValue").repartition(1)
    +    } else {
    +      throw new UnsupportedOperationException(
    +        "No summary table available for this GeneralizedLinearRegressionModel")
    --- End diff --
    
    minor suggestion: it would be nice to add a test to verify this exception is thrown (and
with the right error message using the withClue() check)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message