spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #16891: [SPARK-19318][SQL] Fix to treat JDBC connection p...
Date Mon, 13 Feb 2017 18:32:00 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16891#discussion_r100863061
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
    @@ -31,7 +31,12 @@ class JDBCOptions(
     
       import JDBCOptions._
     
    -  def this(parameters: Map[String, String]) = this(new CaseInsensitiveMap(parameters))
    +  def this(params: Map[String, String]) = {
    +    this(params match {
    +      case cMap: CaseInsensitiveMap => cMap
    +      case _ => new CaseInsensitiveMap(params)
    --- End diff --
    
    I think this is a general problem, let's create an `object CaseInsensitiveMap` and put
this logic there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message