spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NathanHowell <...@git.apache.org>
Subject [GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...
Date Sat, 11 Feb 2017 00:15:23 GMT
Github user NathanHowell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16386#discussion_r100649635
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
    @@ -31,10 +31,17 @@ import org.apache.spark.sql.catalyst.util.{CaseInsensitiveMap, CompressionCodecs
      * Most of these map directly to Jackson's internal options, specified in [[JsonParser.Feature]].
      */
     private[sql] class JSONOptions(
    -    @transient private val parameters: CaseInsensitiveMap)
    +    @transient private val parameters: CaseInsensitiveMap,
    +    defaultColumnNameOfCorruptRecord: String)
       extends Logging with Serializable  {
     
    -  def this(parameters: Map[String, String]) = this(new CaseInsensitiveMap(parameters))
    +  def this(
    +      parameters: Map[String, String],
    +      defaultColumnNameOfCorruptRecord: String = "") = {
    --- End diff --
    
    Yes, it's really not a good solution, but it doesn't make sense to have a corrupt column
name in all use cases. Picking another sentinel could inadvertently conflict with a real column.
It should be `Option[String] = None` but this winds up being a large change that deserves
a separate pull request. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message