spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiangxb1987 <...@git.apache.org>
Subject [GitHub] spark pull request #16873: [SPARK-19509][SQL] Grouping Sets do not respect n...
Date Thu, 09 Feb 2017 16:35:24 GMT
Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16873#discussion_r100348823
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql ---
    @@ -13,5 +18,8 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c GROUPING SETS
((a));
     -- SPARK-17849: grouping set throws NPE #3
     SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c GROUPING SETS ((c));
     
    +-- SPARK-19509: grouping set should honor input nullability
    +SELECT COUNT(1) FROM grouping_null GROUP BY e GROUPING SETS (e);
     
    -
    +DROP VIEW IF EXISTS grouping;
    +DROP VIEW IF EXISTS grouping_null;
    --- End diff --
    
    Nit: Should we leave an extra empty line for this file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message